-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toyota: API is now gas/brake #1189
base: master
Are you sure you want to change the base?
Conversation
0 is almost coasting for down and up hill, appears to be less non-linearity when changing request, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longcontrol.py resets the integral every time you disengage, so it may take a few seconds before it learns the offset on each engagement, issue should be on GM (gas/brake) as well
…ompensating for PCM
generate
78a2742
to
4946b5b
Compare
Need to figure out smoothing without rate limit if possbile
GEAR_PACKET_HYBRID->CAR_MOVEMENT might be some force exerted by the engine/hybrid motors, need to find the ICE equivelent. And BRAKE_PEDAL->BRAKE might be the actual brake percentage! While reviewing some recent routes using the new signal in the CLUTCH message, I discovered why there might still be some sub optimal performance. It appears that Here is switching the acceleration read back signals to show how each is only accurate for brake/gas: |
Needs testing, required for commaai/openpilot#33384
Past PRs for history: commaai/openpilot#29481 // commaai/openpilot#32753